0000680: Dynamic DNS update fails if system is on a LAN segment

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000680

ClearOS

app-syswatch - System Watch

public

2012-07-12 11:56

2012-09-19 14:40

Reporter

bchambers

Assigned To

user2

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

no change required

Platform

OS Version

Product Version

6.2.0

Target Version

6.2.0 Updates

Fixed in Version

Summary

0000680: Dynamic DNS update fails if system is on a LAN segment

Description

If ClearOS is not the gateway, receiving a public IP address, dynamic DNS updates will fail.

sub GetIp()...
..
.
if ( (defined($g_extifs{$extif}->{status}) && ($g_extifs{$extif}->{status} == $STATUS_OK)) &&
         (defined($g_extifs{$extif}->{use_get_ip}) && ($g_extifs{$extif}->{use_get_ip} eq $STATE_ENABLED)) &&
         ($config{use_get_ip} eq $STATE_ENABLED)
        ) {

Should be (please verify):

if ( (defined($g_extifs{$extif}->{status}) && ($g_extifs{$extif}->{status} == $STATUS_OK)) &&
         ((defined($g_extifs{$extif}->{use_get_ip}) && ($g_extifs{$extif}->{use_get_ip} eq $STATE_ENABLED)) ||
         ($config{use_get_ip} eq $STATE_ENABLED))
        ) {

Second two conditions should be grouped by paranthesis, and condition should be OR, not AND.

Tags

No tags attached.

Attached Files

Relationships

Notes
(0000564) user2 2012-09-19 14:39	That's a tortured "if" statement! The "and" logic is intended. Both the interface and the configuration must have "getip" enabled. If the interface is on a public IP, syswatch won't bother using the getip tool. Yes, some folks may use real IPs behind NAT, but that's rare. Covering up for that bad practice would put a lot more stress on the SDN IP referrer tool. Ideally, the "or" logic would be in there though.

Issue History
Date Modified	Username	Field	Change
2012-07-12 11:56	bchambers	New Issue
2012-07-12 11:56	bchambers	Status	new => assigned
2012-07-12 11:56	bchambers	Assigned To	=> user2
2012-07-12 12:01	bchambers	Status	assigned => confirmed
2012-09-19 14:39	user2	Note Added: 0000564
2012-09-19 14:40	user2	Status	confirmed => resolved
2012-09-19 14:40	user2	Resolution	open => no change required
2012-09-19 14:40	user2	Status	resolved => closed

ClearOS Bug Tracker