0000241: Wrong validation of relay host when adding a host with port

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000241

ClearOS

app-smtp - SMTP Server

public

2011-02-26 22:36

2019-03-12 10:24

Reporter

maeztro

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

suspended

Platform

OS Version

Product Version

5.2-SP1

Target Version

Fixed in Version

Summary

0000241: Wrong validation of relay host when adding a host with port

Description

When adding a relay host with port (in the format host:port), the SMTP Server page doesn't validate the presence of the por, thus adding an invalid value to the relayhost Postfix configuration parameter. According to Postfix documentation:

"In the case of SMTP, specify a domain name, hostname, hostname:port, [hostname]:port, [hostaddress] or [hostaddress]:port. The form [hostname] turns off MX lookups."

Because the SMTP Server page doesn't validate the presence of a port on the host string it adds the relay host as [relayhost:port], which is incorrect and breaks the relay host configuration. When a port is present it must be added as [relayhost]:port or relayhost:port.

Attached to this report is a patch that fixes this issue, looking if the relay host being added contains a string in the form "host:port" and if it does then it sets relayhost = [host]:port.

Additional Information

I'm not sure which is the best format to use for the relay host, as the format [host]:port doesn't work for me, just host:port. I don't know if this is related to the port setting or to the fact that I'm connecting to a TLS enabled relay host that listens on port 587 and requires SMTP auth. As documentation says, the use of [ ] turns off MX lookups, is there any reason to do this ? I would think that they should be left turned on.

Tags

No tags attached.

Attached Files

fix_postfix_relayhost_with_port.zip [^] (560 bytes) 2011-02-26 22:36

fix_postfix_relayhost_with_port_v2.zip [^] (1,467 bytes) 2011-03-01 21:44

Relationships

Notes
(0000335) maeztro (reporter) 2011-02-27 18:56 edited on: 2011-02-27 18:57	Take a look to this forum post about the use of MX lookups with the relayhost parameter: http://www.clearfoundation.com/component/option,com_kunena/Itemid,232/catid,14/func,view/id,24765/#24826 [^] IMO, they should be turned on so the notation that should be used is without the [].

(0000336) maeztro (reporter) 2011-03-01 21:44	Attached a new patch version, which additional to hte port validation adds a text field for the relay host port in mail-smtp.php, as discussed here: http://www.clearfoundation.com/component/option,com_kunena/Itemid,232/catid,39/func,view/id,13476/#25004 [^]

(0010941) NickH (developer) 2019-03-12 10:24	Migrated to: https://gitlab.com/clearos/clearfoundation/app-smtp/issues/3 [^]

Issue History
Date Modified	Username	Field	Change
2011-02-26 22:36	maeztro	New Issue
2011-02-26 22:36	maeztro	File Added: fix_postfix_relayhost_with_port.zip
2011-02-27 18:56	maeztro	Note Added: 0000335
2011-02-27 18:57	maeztro	Note Edited: 0000335
2011-02-28 20:43	user2	Status	new => confirmed
2011-02-28 20:53	user2	Severity	major => minor
2011-03-01 21:44	maeztro	File Added: fix_postfix_relayhost_with_port_v2.zip
2011-03-01 21:44	maeztro	Note Added: 0000336
2013-02-02 10:32	user2	Target Version	=> 6.4.0 Updates
2013-07-29 13:58	user2	Target Version	6.4.0 Updates => 6 Future
2014-04-22 13:28	user2	Target Version	6 Future => Future
2015-05-25 05:10	user2	Target Version	Future =>
2019-03-12 10:24	NickH	Note Added: 0010941
2019-03-12 10:24	NickH	Status	confirmed => closed
2019-03-12 10:24	NickH	Resolution	open => suspended

ClearOS Bug Tracker